NH-4000 - Prepare release of v5.0 #693

fredericDelaporte · 2017-09-19T17:10:06Z

NH-4000 - Proposed changes to release notes for v5.0.

~~NH-3845 not included as it does not seem to be fully fixed, see #553.~~

NH-3945 (Antlr3 upgrade) is labeled with "possible breaking changes", but I was unable to determine them.

Elaborated from the Jira list of fixed for 5.0.0. Opened issues (excepted NH-4000) have been removed from the release. (Mostly moved to 5.1, some to 6.0 or nothing.)

Test related items are identified as such, ~~one has been dropped from the list (support of inconclusive results)~~.

Some minor titles adjustment has been done for some issues in order for them to be more explicit. Some others should maybe be reworded, especially bugs which titles are sometimes remotely related to their actual cause.

Previous week I had review all PR with milestone:5.0 and checked their corresponding Jira, then additionally check all closed PR by merged date down to november 2016, so it should not stay some missed change.

Update: Well, thinking about it, there was a constructor change somewhere likely for some factory I have not mention, and do not remember what it was.

fredericDelaporte · 2017-09-19T17:59:51Z

Since it seems not an usual practice, I have added as a separated commit some highlights. To be dropped if considered undesirable there.

About documentation, I am thinking about maybe one lacking point with async: how to mix async and lazy-loading. Users may believe lazy-loading can not be async if they do not know about NHibernateUtil.InitializeAsync (although indirectly documented since NHibernateUtil.Initialize is documented and all IO bound methods are said to have async counterparts). But adding an async section just for that (and maybe re-warning about awaiting each call) would be a bit overkill. And furthermore using such method before each potential lazy-load would be a bit "bloaty".

fredericDelaporte · 2017-09-19T19:41:28Z

The ISession.GetSession(entityMode) is still in 5.0 indeed, but obsolete. So I do not mention it in breaking changes.

hazzik · 2017-09-20T01:45:07Z

NH-3845 not included as it does not seem to be fully fixed, see #553.

The not fixed part has own JIRA issue now: NH-3947.

hazzik · 2017-09-19T20:28:36Z

doc/reference/modules/configuration.xml

@@ -115,7 +115,7 @@ Configuration cfg = new Configuration()
            obtain ADO.NET connections wherever it pleases:
        </para>

-        <programlisting><![CDATA[IDbConnection conn = myApp.GetOpenConnection();
+        <programlisting><![CDATA[DbConnection conn = myApp.GetOpenConnection();


Maybe better to replace with var

Why not. I have mixed feeling on that in documentation context: there is no intellisens there to check what type is the var. But in most cases it should not matter much.

hazzik · 2017-09-19T23:15:20Z

releasenotes.txt

+    * [NH-2444] - Document linq provider
+    * [NH-3094] - Linq does not support unary plus and unary minus operators
+    * [NH-3370] - remove warning about "NHibernate.Type.CustomType -- the custom type * is not serializable"
+    * [NH-3386] - Linq OrderBy NewGuid


Need to update the wording as Guid.NewGuid() isn't yet supported.

hazzik · 2017-09-20T03:32:57Z

Test related items are identified as such, one has been dropped from the list (support of inconclusive results).

Why?

hazzik · 2017-09-20T03:47:11Z

@fredericDelaporte I've updated several titles of issues, so it would need to update in the release notes. Also, some issues were moved from Tasks into Improvements category.

hazzik · 2017-09-20T05:08:13Z

@fredericDelaporte I completely forgot about NH-3919. We have to make it into 5.0

fredericDelaporte · 2017-09-20T09:55:25Z

Why?

I was even considering dropping all tests only changes/fixes as they do not add or change features of the library. User could consider them as just noise for a release changes list. Still they give some more confidence in the library reliability. This one was not doing that. Now we can also let them all in the list: one more does not matter. Or maybe extract them to a separated list at the end (but that will cause more manual work for updating the list).

fredericDelaporte · 2017-09-20T10:08:36Z

@fredericDelaporte I completely forgot about NH-3919. We have to make it into 5.0

Does not look as a small one, at least it implies to do some choices as to whether we re-align on hibernate (automatically switch to datetime 2 for sql server 2008+ instead of having to use a specific not portable type) or not. The automatic switch may cause a bunch of issues for column still using datetime, not datetime2.

If fixing that one we should fix NH-3792 by the way, and maybe the two other linked issues to.

hazzik · 2017-09-20T10:15:06Z

I think it is fine then.

At least, I think, we need to replace DateTimeType with TimestampType, as there are a lot of confusion with cutting the milliseconds part. Because this is, potentially, a huge breaking change and we would need to postpone to 6.0 otherwise.

We will need to register Timestamp as a default type for DateTime (in TypeFactory.RegisterDefaultTypes) and change some of the dialect functions wrongly registered with DateTime, when in fact they have higher precision.

fredericDelaporte · 2017-09-20T11:11:53Z

I may still give a try at NH-3919, with checking what it gives with old datetime columns. Maybe NH-3884 if implemented could give a way to revert back for users who would need it.

hazzik · 2017-09-21T00:58:03Z

releasenotes.txt

@@ -3062,7 +3283,7 @@ Alpha Build 0.3.0.0
 - BatcherImpl and PreparerImpl were combined and code cleaned up thanks to problems found when using Ngpsql (Martijn Boland).
 - ITransaction is now responsible for joining IDbCommand to IDbTransaction instead of IBatcher - if applicable.
 - Modified code to help improve performance of Drivers that don't support multiple Open DataReaders on a single IDbConnection.
- Fixed bug with hbm2net and VelocityRenderer throwing Exception (Carlos Guzm�n �lvarez & Peter Smulovics).
+- Fixed bug with hbm2net and VelocityRenderer throwing Exception (Carlos Guzm�n �lvarez & Peter Smulovics).


Som unicode screw-ups

VS Code gotcha: microsoft/vscode#23997, they read a limited number of bytes before guessing the encoding. (At first only 512, they have increased that, but of course if they do not read the whole file they will still screw some cases...) Going to fix by switching the file to UTF8+BOM.

See microsoft/vscode@bfe1d2b, the new limit is 4096 bytes. Far to reach our first windows-1252 specific character in this file.

fredericDelaporte · 2017-09-21T11:12:54Z

Rebased, squashed, corruption fixed, preventing it to occur again by re-encoding to UTF8 with BOM.

fredericDelaporte · 2017-09-30T21:07:28Z

doc/reference/modules/basic_mapping.xml

-                 <programlisting>
-           <![CDATA[<hibernate-mapping
+                 </areaspec>
+                 <programlisting><![CDATA[<hibernate-mapping


This is what wrecks numbering here.

fredericDelaporte · 2017-10-04T17:25:13Z

Release notes amended according to @oskarb e-mail.

fredericDelaporte · 2017-10-06T10:06:20Z

Notes fixes squashed.

hazzik · 2017-10-10T08:53:15Z

@fredericDelaporte are you happy with the state of the release?

fredericDelaporte

State good enough for me.

igitur · 2017-10-10T10:19:33Z

Congratulations on this milestone.

hazzik · 2017-10-10T10:59:59Z

thanks @igitur

fredericDelaporte added this to the 5.0 milestone Sep 19, 2017

fredericDelaporte force-pushed the NH-4000 branch from 855ef86 to e5dc48b Compare September 19, 2017 17:20

fredericDelaporte force-pushed the NH-4000 branch from 68d8128 to 26f5554 Compare September 19, 2017 19:37

fredericDelaporte force-pushed the NH-4000 branch from dd2300f to a76bff6 Compare September 19, 2017 19:59

hazzik previously approved these changes Sep 20, 2017

View reviewed changes

hazzik changed the title ~~NH-4000 - Release notes for v5.0.~~ NH-4000 - Prepare release of v5.0. Sep 20, 2017

fredericDelaporte dismissed hazzik’s stale review via 674cec0 September 20, 2017 11:13

hazzik reviewed Sep 21, 2017

View reviewed changes

hazzik changed the title ~~NH-4000 - Prepare release of v5.0.~~ NH-4000 - Prepare release of v5.0 Sep 21, 2017

fredericDelaporte force-pushed the NH-4000 branch from 9399233 to 3f74a58 Compare September 21, 2017 11:10

fredericDelaporte mentioned this pull request Sep 22, 2017

NH-3884 - Default DateTime type can not be overridden #702

Merged

fredericDelaporte force-pushed the NH-4000 branch 2 times, most recently from 7df3aad to 86f3a3a Compare September 30, 2017 02:05

fredericDelaporte commented Sep 30, 2017

View reviewed changes

fredericDelaporte force-pushed the NH-4000 branch 3 times, most recently from ba52c3f to b49addd Compare October 4, 2017 17:24

fredericDelaporte force-pushed the NH-4000 branch from 4494e9a to c1ae2fb Compare October 6, 2017 10:05

fredericDelaporte force-pushed the NH-4000 branch from c1ae2fb to 404b66c Compare October 9, 2017 09:52

hazzik force-pushed the NH-4000 branch from 404b66c to 5152e7e Compare October 10, 2017 08:37

fredericDelaporte and others added 5 commits October 10, 2017 21:48

Obsolete fixes in documentation.

c9f2e64

Missing unmerged assemblies in required bin.

2934678

NH-4000 - Release notes

9618548

Wording fixes in code documentation

a65ba33

NH-4000 - Set version 5.0.0

71b99d1

hazzik force-pushed the NH-4000 branch from 5152e7e to 71b99d1 Compare October 10, 2017 08:51

fredericDelaporte commented Oct 10, 2017

View reviewed changes

hazzik merged commit c2c93d9 into nhibernate:master Oct 10, 2017

fredericDelaporte deleted the NH-4000 branch October 10, 2017 15:00

fredericDelaporte added the r: Fixed label Oct 10, 2017

NH-4000 - Prepare release of v5.0 #693

NH-4000 - Prepare release of v5.0 #693

Uh oh!

Conversation

fredericDelaporte commented Sep 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fredericDelaporte commented Sep 19, 2017

Uh oh!

fredericDelaporte commented Sep 19, 2017

Uh oh!

hazzik commented Sep 20, 2017

Uh oh!

hazzik Sep 19, 2017

Choose a reason for hiding this comment

Uh oh!

fredericDelaporte Sep 20, 2017

Choose a reason for hiding this comment

Uh oh!

hazzik Sep 19, 2017

Choose a reason for hiding this comment

Uh oh!

hazzik commented Sep 20, 2017

Uh oh!

hazzik commented Sep 20, 2017

Uh oh!

hazzik commented Sep 20, 2017 • edited by fredericDelaporte Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fredericDelaporte commented Sep 20, 2017

Uh oh!

fredericDelaporte commented Sep 20, 2017

Uh oh!

hazzik commented Sep 20, 2017

Uh oh!

fredericDelaporte commented Sep 20, 2017

Uh oh!

hazzik Sep 21, 2017

Choose a reason for hiding this comment

Uh oh!

fredericDelaporte Sep 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fredericDelaporte commented Sep 21, 2017

Uh oh!

fredericDelaporte Sep 30, 2017

Choose a reason for hiding this comment

Uh oh!

fredericDelaporte commented Oct 4, 2017

Uh oh!

fredericDelaporte commented Oct 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hazzik commented Oct 10, 2017

Uh oh!

fredericDelaporte left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igitur commented Oct 10, 2017

Uh oh!

hazzik commented Oct 10, 2017

Uh oh!

Uh oh!

fredericDelaporte commented Sep 19, 2017 •

edited

Loading

hazzik commented Sep 20, 2017 •

edited by fredericDelaporte

Loading

fredericDelaporte Sep 21, 2017 •

edited

Loading

fredericDelaporte commented Oct 6, 2017 •

edited

Loading

fredericDelaporte left a comment •

edited

Loading